feat(core,isthmus): add dml support to SqlToSubstrait #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
reviewed
Jul 8, 2025
isthmus/src/test/java/io/substrait/isthmus/SqlToSubstraitTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/SqlToSubstraitTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/SqlToSubstraitTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/SqlToSubstraitTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
from
1f49da2 to
7291c94
Compare
|
Hi @vbarua, please take a look at the new changes. If the taken approach makes sense, I will merge it with big changes from @nielspardon. Thanks! |
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
2 times, most recently
from
0036523 to
b61274e
Compare
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
from
b61274e to
71533be
Compare
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
from
71533be to
fce1ce4
Compare
ZorinAnton
changed the title
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
2 times, most recently
from
49646d9 to
21cf45d
Compare
nielspardon
reviewed
Jul 30, 2025
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
2 times, most recently
from
761d3fc to
4974a6b
Compare
nielspardon
reviewed
Jul 31, 2025
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
ZorinAnton
force-pushed
the
zor-sql-to-dml
branch
from
4974a6b to
74f3e5f
Compare
nielspardon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, splitting the PR #428 into dml and ddl parts. This PR is for dml support.
The class
SubstraitRelVisitornow supports the following operations for theTableModifynode: