feat(spark): dialect YAML file for spark converter #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-coleman
force-pushed
the
dialect
branch
3 times, most recently
from
d7727de to
1f8756f
Compare
andrew-coleman
force-pushed
the
dialect
branch
3 times, most recently
from
4dc3359 to
03da734
Compare
Adds the formal dialect definition for the Spark converter. The file is generated from code which extracts the relevant information from the exisitng FunctionMapper definitions. This ensures that the dialect YAML remains in-sync with the code. Tests have been introduced to ensure that the dialect conforms to the schema (defined in teh base substrait library), and that the published dialect YAML is the equivalent to one that would be generated from the current code. Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
andrew-coleman
force-pushed
the
dialect
branch
from
03da734 to
598e441
Compare
nielspardon
reviewed
Oct 20, 2025
Comment on lines
+54
to
+57
| // The following will fail if the generated dialect differs from the published one. | ||
| // If this is caused by an intentional change, the published dialect should be regenerated using: | ||
| // `./gradlew dialect` | ||
| assertResult(publishedDialect)(genDialect) |
There was a problem hiding this comment.
great that you thought of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the formal dialect definition for the Spark converter. The file is generated from code which extracts the relevant information from the exisitng FunctionMapper definitions. This ensures that the dialect YAML remains in-sync with the code.
Tests have been introduced to ensure that the dialect conforms to the schema (defined in teh base substrait library), and that the published dialect YAML is the equivalent to one that would be generated from the current code.