Skip to content

Commit

Permalink
Remove "This incident will be reported." from user warnings.
Browse files Browse the repository at this point in the history
This used to indicate that email had been sent to the administrator
telling them that someone tried to run sudo.  Whether or not sudo
sends email is now configurable, so the warning may not be accurate.
It is also confusing to the user since they will not know who the
incident is being reported to.  See also https://xkcd.com/838/
  • Loading branch information
millert committed Feb 4, 2022
1 parent 4d0aeea commit 6aa320c
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions plugins/sudoers/logging.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* SPDX-License-Identifier: ISC
*
* Copyright (c) 1994-1996, 1998-2020 Todd C. Miller <Todd.Miller@sudo.ws>
* Copyright (c) 1994-1996, 1998-2022 Todd C. Miller <Todd.Miller@sudo.ws>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
Expand Down Expand Up @@ -311,11 +311,10 @@ log_denial(int status, bool inform_user)

if (ISSET(status, FLAG_NO_USER)) {
sudo_printf(SUDO_CONV_ERROR_MSG, _("%s is not in the sudoers "
"file. This incident will be reported.\n"), user_name);
"file.\n"), user_name);
} else if (ISSET(status, FLAG_NO_HOST)) {
sudo_printf(SUDO_CONV_ERROR_MSG, _("%s is not allowed to run sudo "
"on %s. This incident will be reported.\n"),
user_name, user_srunhost);
"on %s.\n"), user_name, user_srunhost);
} else if (ISSET(status, FLAG_NO_CHECK)) {
sudo_printf(SUDO_CONV_ERROR_MSG, _("Sorry, user %s may not run "
"sudo on %s.\n"), user_name, user_srunhost);
Expand Down

33 comments on commit 6aa320c

@stvmln86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of an era.

@bruttosozial
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP.

@lexisother
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@DarkKapla
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@spacekookie
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember being a first year CS student and trying to run sudo on university infrastructure for the first time and getting scared shitless of that message.
I ended up trying to find a member of faculty for half an hour to check if I was in trouble or not. Once I found someone to talk to they just laughed.

Gonna miss this message 😂

@BenBE
Copy link

@BenBE BenBE commented on 6aa320c Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@HanEmile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@yeti0904
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@tildezero
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@foxwyn
Copy link

@foxwyn foxwyn commented on 6aa320c Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@DistroHopper39B
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@RomeuG
Copy link

@RomeuG RomeuG commented on 6aa320c Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@pistasjis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@Rexogamer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly the end of an era...

@Explosion-Scratch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@xadacka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@xoiga123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I legit wrote a suggestion in uni using sudo because I thought someone from the IT staff will read it 💀

@Paranoid-Dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@farcaller
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how will Santa know about privilege escalations now? 🤔

@giorgiovilardo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@Elycin
Copy link

@Elycin Elycin commented on 6aa320c Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@rcastellotti
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@miloserdev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@GiorgioRen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@lvwrence
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@ashkitten
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@Midou36O
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@etherealsunshine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@eshoyfer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@VikingPingvin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@sermah
Copy link

@sermah sermah commented on 6aa320c Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@sreedevk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@millert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning was restored in a slightly altered form in 9757d29

Please sign in to comment.