make filter values comply with postrest rules #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what's going on with the test. The test runs fine for me locally. Is the test flaky? |
|
Yea ignore that one, there are some issues with turbine. I'll look at the PR tomorrow. |
jan-tennert
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix for #1035
What is the current behavior?
Values are passed through without being modified.
What is the new behavior?
Values have backslashes and quotes added a backslash before, and values containing reserved characters are wrapped in quotes.
Additional context
URL grammar is specified here: https://docs.postgrest.org/en/v13/references/api/url_grammar.html#reserved-chars
It's not clear if strings containing a backslash or quote need to be quoted.