Skip to content

make filter values comply with postrest rules #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

make filter values comply with postrest rules #1036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions Realtime/src/commonMain/kotlin/io/github/jan/supabase/realtime/PostgresChangeFilter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,18 @@ class PostgresChangeFilter(private val event: String, private val schema: String
*/
fun filter(filter: FilterOperation) {
val filterValue = when(filter.operator) {
FilterOperator.EQ, FilterOperator.NEQ, FilterOperator.GT, FilterOperator.GTE, FilterOperator.LT, FilterOperator.LTE -> filter.value.toString()
FilterOperator.EQ,
FilterOperator.NEQ,
FilterOperator.GT,
FilterOperator.GTE,
FilterOperator.LT,
FilterOperator.LTE ->
escapeValue(filter.value)
FilterOperator.IN -> {
if(filter.value is List<*>) {
(filter.value as List<*>).joinToString(",", prefix = "(", postfix = ")") { it.toString() }
(filter.value as List<*>).joinToString(",", prefix = "(", postfix = ")") { escapeValue(it) }
} else {
filter.value.toString()
escapeValue(filter.value)
}
}
else -> throw UnsupportedOperationException("Unsupported filter operator: ${filter.operator}")
Expand All @@ -53,4 +59,17 @@ class PostgresChangeFilter(private val event: String, private val schema: String
@SupabaseInternal
fun buildConfig() = PostgresJoinConfig(schema, table, filter, event)

}
}

private val quotedCharacters = listOf(",", ".", ":", "(", ")")

private fun escapeValue(value: Any?): String {
val asString = value.toString()
.replace("\\", "\\\\")
.replace("\"", "\\\"")
return if (quotedCharacters.any { asString.contains(it) }) {
"\"$asString\""
} else {
asString
}
}
Loading