Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

fix: supabase/supabase#1915 encode query string parameter values #98

Merged
merged 1 commit into from
Jun 13, 2021
Merged

fix: supabase/supabase#1915 encode query string parameter values #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/GoTrueApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default class GoTrueApi {
let headers = { ...this.headers }
let queryString = ''
if (options.redirectTo) {
queryString = '?redirect_to=' + options.redirectTo
queryString = '?redirect_to=' + encodeURIComponent(options.redirectTo)
}
const data = await post(`${this.url}/signup${queryString}`, { email, password }, { headers })
let session = { ...data }
Expand Down Expand Up @@ -75,7 +75,7 @@ export default class GoTrueApi {
let headers = { ...this.headers }
let queryString = '?grant_type=password'
if (options.redirectTo) {
queryString += '&redirect_to=' + options.redirectTo
queryString += '&redirect_to=' + encodeURIComponent(options.redirectTo)
}
const data = await post(`${this.url}/token${queryString}`, { email, password }, { headers })
let session = { ...data }
Expand All @@ -101,7 +101,7 @@ export default class GoTrueApi {
let headers = { ...this.headers }
let queryString = ''
if (options.redirectTo) {
queryString += '?redirect_to=' + options.redirectTo
queryString += '?redirect_to=' + encodeURIComponent(options.redirectTo)
}
const data = await post(`${this.url}/magiclink${queryString}`, { email }, { headers })
return { data, error: null }
Expand All @@ -125,7 +125,7 @@ export default class GoTrueApi {
let headers = { ...this.headers }
let queryString = ''
if (options.redirectTo) {
queryString += '?redirect_to=' + options.redirectTo
queryString += '?redirect_to=' + encodeURIComponent(options.redirectTo)
}
const data = await post(`${this.url}/invite${queryString}`, { email }, { headers })
return { data, error: null }
Expand All @@ -149,7 +149,7 @@ export default class GoTrueApi {
let headers = { ...this.headers }
let queryString = ''
if (options.redirectTo) {
queryString += '?redirect_to=' + options.redirectTo
queryString += '?redirect_to=' + encodeURIComponent(options.redirectTo)
}
const data = await post(`${this.url}/recover${queryString}`, { email }, { headers })
return { data, error: null }
Expand Down Expand Up @@ -199,12 +199,12 @@ export default class GoTrueApi {
scopes?: string
}
) {
let urlParams: string[] = [`provider=${provider}`]
let urlParams: string[] = [`provider=${encodeURIComponent(provider)}`]
if (options?.redirectTo) {
urlParams.push(`redirect_to=${options.redirectTo}`)
urlParams.push(`redirect_to=${encodeURIComponent(options.redirectTo)}`)
}
if (options?.scopes) {
urlParams.push(`scopes=${options.scopes}`)
urlParams.push(`scopes=${encodeURIComponent(options.scopes)}`)
}
return `${this.url}/authorize?${urlParams.join('&')}`
}
Expand Down
4 changes: 2 additions & 2 deletions test/__snapshots__/provider.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ exports[`signIn() with Provider 1`] = `"http://localhost:9999/authorize?provider

exports[`signIn() with Provider 2`] = `"google"`;

exports[`signIn() with Provider can append a redirectUrl 1`] = `"http://localhost:9999/authorize?provider=google&redirect_to=https://localhost:9000/welcome"`;
exports[`signIn() with Provider can append a redirectUrl 1`] = `"http://localhost:9999/authorize?provider=google&redirect_to=https%3A%2F%2Flocalhost%3A9000%2Fwelcome"`;

exports[`signIn() with Provider can append a redirectUrl 2`] = `"google"`;

exports[`signIn() with Provider can append multiple options 1`] = `"http://localhost:9999/authorize?provider=github&redirect_to=https://localhost:9000/welcome&scopes=repo"`;
exports[`signIn() with Provider can append multiple options 1`] = `"http://localhost:9999/authorize?provider=github&redirect_to=https%3A%2F%2Flocalhost%3A9000%2Fwelcome&scopes=repo"`;

exports[`signIn() with Provider can append multiple options 2`] = `"github"`;

Expand Down