fix: add email as verification type for email OTPs
#885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Jan 12, 2023
|
🎉 This PR is included in version 2.40.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kangmingtay
added a commit
to supabase/auth-js
that referenced
this pull request
Apr 4, 2023
## What kind of change does this PR introduce? * Update the types to include `email` as a verification type * Related gotrue PR: supabase/auth#885
This was referenced May 2, 2023
altryne
added a commit
to altryne/supabase
that referenced
this pull request
May 2, 2023
… for emails `email` Fixes supabase#14089 supabase#14089 Specifies that `email` is the right type for OTP verification and adds `signup` and `magiclink` to be deprecated per supabase/auth#885 and supabase/auth-js#642
sh47dow
pushed a commit
to sh47dow/supabase
that referenced
this pull request
May 29, 2023
… for emails `email` Fixes supabase#14089 supabase#14089 Specifies that `email` is the right type for OTP verification and adds `signup` and `magiclink` to be deprecated per supabase/auth#885 and supabase/auth-js#642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
email. Currently, it's impossible to tell whether the verification type should be set to "signup" or "magiclink" when a user enters an OTP. As such, developers have to resort to tryingmagiclinkfirst, then catching the error and trying withsignupnext.signup,magiclinktypes forPOST /verifyExample request: