Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify and log in through OTP - obsolete/incorrect information #14089

Closed
altryne opened this issue May 2, 2023 · 0 comments · Fixed by #14091
Closed

Verify and log in through OTP - obsolete/incorrect information #14089

altryne opened this issue May 2, 2023 · 0 comments · Fixed by #14091
Labels
documentation Improvements or additions to documentation

Comments

@altryne
Copy link
Contributor

altryne commented May 2, 2023

Improve documentation

Verify and log in through OTP documentation

Link

https://supabase.com/docs/reference/javascript/auth-verifyotp

Describe the problem

The current page lists these types of verification signup, magiclink, recovery, invite or email_change however, both magiclink and signup have been deprecated in supabase/auth#885 in favor of email which is not listed there.

email works for both newly created accounts and returning accounts who are logging in just now.

Describe the improvement

email should replace both the magiclink and signup types as per the Pull Request

Additional context

The above PR describes a fix for a problem with auth, where supabase would return a 401 for valid tokens every new user registration. IMO it's a huge deal, and have probably turned away so many folks that tried to use our product.

@altryne altryne added the documentation Improvements or additions to documentation label May 2, 2023
altryne added a commit to altryne/supabase that referenced this issue May 2, 2023
… for emails `email`

Fixes supabase#14089 supabase#14089 

Specifies that `email` is the right type for OTP verification and adds `signup` and `magiclink` to be deprecated per supabase/auth#885 and supabase/auth-js#642
sh47dow pushed a commit to sh47dow/supabase that referenced this issue May 29, 2023
… for emails `email`

Fixes supabase#14089 supabase#14089 

Specifies that `email` is the right type for OTP verification and adds `signup` and `magiclink` to be deprecated per supabase/auth#885 and supabase/auth-js#642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
1 participant