fix: allow deno functions to reach host OS #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4042249922
💛 - Coveralls |
|
Does this also work with other daemons? I don't think we've used Docker Desktop-isms so far. |
|
Haven't tested on other daemons but it should be safe to add because this config only updates the |
soedirgo
approved these changes
Jan 30, 2023
sweatybridge
changed the title
|
🎉 This PR is included in version 1.35.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
no consistent way for locally served functions to reach host OS
What is the new behavior?
Starting from Docker Engine
20.04, it's now possible to usehost.docker.internalconsistently across platforms https://stackoverflow.com/a/61424570Additional context
supabase/supabase#9837 (reply in thread)