fix(db): make local hostname configurable for docker-in-docker #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweatybridge
changed the title
sweatybridge
changed the title
sweatybridge
force-pushed
the
daemon-host
branch
from
b58de0c
to
84735cb
Compare
Pull Request Test Coverage Report for Build 7545435844
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix #1603
What is the current behavior?
supabase startfails in GitLab CI becausedocker:dinddoes not expose service ports on localhost.What is the new behavior?
Make local hostname configurable so that docker daemon address can be used instead of 127.0.0.1.
This change also supports use cases where docker daemon is installed on a remote machine.
Additional context
Add any other context or screenshots.