Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functions): respect DENO_AUTH_TOKENS #968

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix(functions): respect DENO_AUTH_TOKENS #968

merged 3 commits into from
Mar 30, 2023

Conversation

soedirgo
Copy link
Member

Fixes #959

@soedirgo soedirgo requested a review from laktek March 29, 2023 16:44
@soedirgo soedirgo requested a review from a team as a code owner March 29, 2023 16:44
sweatybridge
sweatybridge requested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest using env map file instead of forwarding cli env var

@coveralls
Copy link

coveralls commented Mar 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4561314083

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.833%
Totals Coverage Status
Change from base Build 4561049659: 0.0%
Covered Lines: 4128
Relevant Lines: 6676
💛 - Coveralls

@soedirgo soedirgo enabled auto-merge March 30, 2023 06:31
@soedirgo soedirgo merged commit f82897d into main Mar 30, 2023
@soedirgo soedirgo deleted the fix/deno-auth-tokens branch March 30, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

@laktek laktek laktek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edge function bundling fails if code is loaded from private source (DENO_AUTH_TOKENS)
4 participants
@soedirgo @coveralls @laktek @sweatybridge