Skip to content

fix: handle invalid paths to bundle command #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: handle invalid paths to bundle command #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
mod logger;

use anyhow::{anyhow, Error};
use anyhow::{anyhow, bail, Error};
use base::commands::start_server;
use base::server::WorkerEntrypoints;
use clap::builder::FalseyValueParser;
Expand Down Expand Up @@ -136,8 +136,13 @@ fn main() -> Result<(), anyhow::Error> {
.unwrap();

let path = PathBuf::from(entry_point_path.as_str());
if !path.exists() {
bail!("entrypoint path does not exist ({})", path.display());
}

let mut emitter_factory = EmitterFactory::new();
let maybe_import_map = load_import_map(import_map_path.clone())?;
let maybe_import_map = load_import_map(import_map_path.clone())
.map_err(|e| anyhow!("import map path is invalid ({})", e))?;
let mut maybe_import_map_url = None;
if maybe_import_map.is_some() {
let abs_import_map_path =
Expand Down