refactor: set v8 flags before initialize v8 platform #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the v8 platform had initialized, it was no longer able to set the v8 flags, so it is necessary to adjust the invocation order of the set v8 flag function to avoid v8's static assertion. (cherry picked from commit bd19752)
nyannyacha
force-pushed
the
apply-v8-flag-before-init
branch
from
e4a30ba to
2d4d230
Compare
laktek
approved these changes
Jan 3, 2024
|
Thanks for the contribution @nyannyacha (sorry for the delay in merging, I was on holidays) |
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, Refactor
Description
After #227 the platform is initialized explicitly at the entry point. However, after initializing the platform, it was no longer able to set the v8 flags [1] [2] [3], so it is necessary to adjust the invocation order of the set v8 flag function to avoid v8's static assertion.