fix(sb_graph): checking whether the path is relative and unix format while reading module path #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while reading module path (cherry picked from commit 999f625653b456d2ddf049f19ff147c5a3d27095)
(cherry picked from commit 3ad82a6bb12dbb9c95e98f4f51b0c7491d60deca)
laktek
approved these changes
Feb 1, 2024
laktek
approved these changes
Feb 1, 2024
|
🎉 This PR is included in version 1.33.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
Description
Instead of letting the panic leak out by failing to strip a leading slash from the given module path, I add some assertions and make sure that things usually proceed instead of panicking when possible.
I don't know whether the problem is caused by the specifier being formatted to follow the Windows path format when ESZip is created in a Windows environment or caused by there being no slashes.
Because I currently don't have a Windows machine, so I take the most conservative approach possible to add logic to relax the leading slash restrictions.