Skip to content

fix(sb_core): adjusting http handler to be compatible with oak@13.0.0 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(sb_core): adjusting http handler to be compatible with oak@13.0.0 #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions crates/sb_core/js/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,15 @@ async function serve(args1, args2) {
opts['handler'] = args1;
} else if (typeof args1 === 'object' && typeof args2 === 'function') {
opts['handler'] = args2;
} else {
if (typeof handler !== 'function') {
throw new TypeError('A handler function must be provided.');
} else if (typeof args1 === 'object') {
if (typeof args1['handler'] === 'function') {
opts['handler'] = args1['handler'];
}
if (typeof args1['onListen'] === 'function') {
opts['onListen'] = args1['onListen'];
}
} else {
throw new TypeError('A handler function must be provided.');
}

let serve;
Expand All @@ -90,7 +95,14 @@ async function serve(args1, args2) {
serve = serveHttp(conn);
for await (const e of serve) {
try {
const res = await opts['handler'](e.request);
const res = await opts['handler'](e.request, {
remoteAddr: {
port: opts.port,
hostname: opts.hostname,
transport: opts.transport
}
});

e.respondWith(res);
} catch (error) {
console.error(error);
Expand All @@ -100,6 +112,11 @@ async function serve(args1, args2) {
};

const finished = (async () => {
opts['onListen']?.({
hostname: opts.hostname,
port: opts.port
});

for await (const conn of listener) {
handleHttp(conn);
}
Expand Down