fix: thread safe handle may no longer have an isolate pointer #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no explicit lifetime synchronization path between the supervisor and isolate, so we cannot assume that `Isolate::request_interrupt` will always be scheduled. The `IsolateInterruptData` passed as an argument has always been passed to `Box::into_raw`, so if the isolation is ever destroyed, the step of converting it back to a `Box<T>` to free the memory is omitted. We should have looked at the result of the `request_interrupt` call and freed the passed arguments in some cases, but we didn't, which led to a memory leak. (cherry picked from commit 2790fa4)
laktek
approved these changes
Feb 6, 2024
|
🎉 This PR is included in version 1.34.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
There is no explicit lifetime synchronization path between the supervisor and isolate, so we cannot assume that
Isolate::request_interruptwill always be scheduled.The
IsolateInterruptDatapassed as an argument has always been passed toBox::into_raw, so if the isolation is ever destroyed, the step of converting it back to aBox<T>to free the memory is omitted. We should have looked at the result of therequest_interruptcall and freed the passed arguments in some cases, but we didn't, which led to a memory leak.