fix(sb_workers): don't propagate promise rejection on request body streaming failure #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
For a promise to a WritableStream that streams the body of an inbound request to a user worker, the promise might be rejected in some cases.
Previously, if this promise was rejected, an exception to this rejection would be propagated to the caller.
However, propagating exceptions for these
sent
is turns out to be undesirable.This is because the user worker may consume the request object abnormally, or
op_user_worker_fetch_send
may drop the channel object in the body under the request object, causing the promise to be rejected.Therefore, we should always expose only the result for
res
to the caller.Fixes #366