chore: introduce tracing
#375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laktek
approved these changes
Jun 24, 2024
|
🎉 This PR is included in version 1.54.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement
Description
Introduces
tracingcrate to improve the edge runtime debugging experience.In this PR, I'm not trying to apply tracing to all of the codebase, just the
sb_module_loadercrate. (There's nothing special about this 😅)Changes
cli: Changed the behavior of the
-v--verbosecli flag incli/tracingfeature flagWhen this feature flag is enabled and
-vor--verboseflag is set, detailed tracing span events are output to the console.With
-vor--verboseflag... 2024-06-24T03:07:11.447652Z DEBUG ThreadId(04) load{specifier="https://deno.land/std/http/status.ts"}: sb_module_loader::standalone::standalone_module_loader: new 2024-06-24T03:07:11.447670Z DEBUG ThreadId(04) load{specifier="https://deno.land/std/http/status.ts"}: sb_module_loader::standalone::standalone_module_loader: enter 2024-06-24T03:07:11.447727Z DEBUG ThreadId(04) load{specifier="https://deno.land/std/http/status.ts"}: sb_module_loader::standalone::standalone_module_loader: exit 2024-06-24T03:07:11.447744Z DEBUG ThreadId(04) load{specifier="https://deno.land/std/http/status.ts"}: sb_module_loader::standalone::standalone_module_loader: close time.busy=57.0µs time.idle=35.7µs ...