Skip to content

fix: expose sessionToken to s3 fs config #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

fix: expose sessionToken to s3 fs config #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/fs/impl/s3_fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ impl S3Fs {
pub struct S3CredentialsObject {
access_key_id: Cow<'static, str>,
secret_access_key: Cow<'static, str>,
session_token: Option<Cow<'static, str>>,
expires_after: Option<u64>,
}

Expand All @@ -126,7 +127,7 @@ impl S3CredentialsObject {
Credentials::new(
self.access_key_id,
self.secret_access_key,
None,
self.session_token.map(|it| it.to_string()),
self
.expires_after
.map(Duration::from_secs)
Expand Down Expand Up @@ -394,7 +395,7 @@ impl deno_fs::FileSystem for S3Fs {
}

#[instrument(
level = "trace",
level = "trace",
skip(self, options, _access_check),
fields(?options, has_access_check = _access_check.is_some()),
err(Debug)
Expand Down