fix(api): Implement storable trait to make it more reliable to store configs in the db #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
changed the title
imor
reviewed
Aug 26, 2025
etl-api/src/configs/destination.rs
Outdated
| }, | ||
| } | ||
|
|
||
| impl Storable for EncryptedStoredDestinationConfig {} |
There was a problem hiding this comment.
Rename trait to Store as Rust traits are named like that without the able suffix.
Damn, made a mistake will fix. |
iambriccardo
force-pushed
the
riccardobusetti/fix/config
branch
from
3509b89 to
657ea15
Compare
iambriccardo
force-pushed
the
riccardobusetti/fix/config
branch
from
657ea15 to
f4ddc9e
Compare
imor
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug for which we were storing the wrong config in the database, causing issue while deserializing.
This is a big problem which can be partially solved if we make sure via traits that we are only serializing and deserializing types that are
Storable.