Skip to content

fix: revert invoke function signature #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Conversation

inian
Copy link
Member

@inian inian commented Aug 15, 2022

what we had in v1 was good. Having an object to pass in is better cos all arguments except function name we have are optional.

Also making invoke a generic type function so that you can type the value returned by your function

what we had in v1 was good. Having an object to pass in is better cos all objects we have are optional.

Also making invoke a generic type function so that you can type the value returned by your function
@inian inian requested review from soedirgo and thorwebdev August 15, 2022 09:16
Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inian inian merged commit b8d8c84 into next Aug 15, 2022
@inian inian deleted the invoke-function-signature branch August 15, 2022 10:11
@github-actions
Copy link

🎉 This PR is included in version 1.4.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants