Feat: add triggers endpoints #116
Conversation
|
Adding the following list to keep track of development. PR Status:
|
This comment has been minimized.
This comment has been minimized.
|
@kiwicopple @soedirgo I have a bit more work to follow up 987f84f but wanted to push up my progress so everyone can play around with the endpoints and provide feedback. |
w3b6x9
force-pushed
the
feat/add_triggers
branch
2 times, most recently
from
1f9fc50 to
263b1c6
Compare
src/lib/PostgresMetaTriggers.ts
Outdated
| private splitQualifiedName(schemas: string[], fullName: string): string[] { | ||
| const names = [] | ||
| const sortedDescSchemas = schemas.sort((a, b) => b.length - a.length) | ||
|
|
||
| for (const schema of sortedDescSchemas) { | ||
| const startIdx = fullName.indexOf(schema) | ||
| const splitIdx = schema.length | ||
|
|
||
| if (startIdx === 0 && fullName[splitIdx] === '.') { | ||
| names.push(fullName.slice(0, splitIdx)) | ||
| names.push(fullName.slice(splitIdx + 1)) | ||
| break | ||
| } | ||
| } | ||
|
|
||
| return names[0] ? names : [fullName] | ||
| } | ||
| } |
There was a problem hiding this comment.
@soedirgo this is something we discussed a few days ago about escaping qualified table names. Even though this has to make an additional query for existing schemas, thought it covers the edge case when schema name itself has period(s). It doesn't cover every edge case of qualified table names but I think it's more than good enough for now. Let me know what you think!
test/integration/index.spec.js
Outdated
| describe('/triggers', () => { | ||
| const trigger = { | ||
| name: 'test_trigger', | ||
| table: 'public.users_audit', |
There was a problem hiding this comment.
I see you have a fully qualified function in the triggers logic, but I think on all the other routes we use table and schema. I think that's a bit cleaner
There was a problem hiding this comment.
@kiwicopple sounds good, I'll go and make the changes.
At this point we are returning tiggers but the rest of the CRUD is not working
w3b6x9
force-pushed
the
feat/add_triggers
branch
2 times, most recently
from
f03f85b to
5492411
Compare
|
@soedirgo thanks so much for the review! |
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Feat: add triggers endpoints
What kind of change does this PR introduce?
Fix #114