fix: alter column uppercase type #154
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -479,3 +479,51 @@ Object { | |
|
|
||
| await pgMeta.tables.remove(testTable!.id) | ||
| }) | ||
|
|
||
| // https://github.com/supabase/supabase/issues/3553 | ||
| test('alter column to type with uppercase', async () => { | ||
| const { data: testTable } = await pgMeta.tables.create({ name: 't' }) | ||
| await pgMeta.query('CREATE TYPE "T" AS ENUM ()') | ||
|
|
||
| let res = await pgMeta.columns.create({ | ||
| table_id: testTable!.id, | ||
| name: 'c', | ||
| type: 'text', | ||
| is_unique: false, | ||
| }) | ||
| res = await pgMeta.columns.update(res.data!.id, { type: 'T' }) | ||
| expect(res).toMatchInlineSnapshot( | ||
| { | ||
| data: { | ||
| id: expect.stringMatching(/^\d+\.\d+$/), | ||
|
There was a problem hiding this comment. looks like you already have a property matcher? any reason for the comment above? There was a problem hiding this comment. Answered above #154 (comment) |
||
| table_id: expect.any(Number), | ||
| }, | ||
| }, | ||
| ` | ||
| Object { | ||
| "data": Object { | ||
| "comment": null, | ||
| "data_type": "USER-DEFINED", | ||
| "default_value": null, | ||
| "enums": Array [], | ||
| "format": "T", | ||
| "id": StringMatching /\\^\\\\d\\+\\\\\\.\\\\d\\+\\$/, | ||
| "identity_generation": null, | ||
| "is_identity": false, | ||
| "is_nullable": true, | ||
| "is_unique": false, | ||
| "is_updatable": true, | ||
| "name": "c", | ||
| "ordinal_position": 1, | ||
| "schema": "public", | ||
| "table": "t", | ||
| "table_id": Any<Number>, | ||
| }, | ||
| "error": null, | ||
| } | ||
| ` | ||
| ) | ||
|
|
||
| await pgMeta.tables.remove(testTable!.id) | ||
| await pgMeta.query('DROP TYPE "T"') | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soedirgo we should use Property matchers if the
idis changing and we don't care. We shouldn't recommend doingupdateSnapshotbecause it will too easily introduce regressionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I've started using it on newer tests - I deferred using it when I did the Jest migration because it was a pain to apply for all cases (some
idare nested in objects in arrays - need preprocessing there). I'll create an issue to use property matchers on existing tests.For now I think it's ok to temporarily keep
ids and use--updateSnapshot.