chore(typegen): Extract metadata generation to function #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata collection for types was previously in the TypeScript generator route. This PR pulls it out into a separate function, which should make it easier to create type generators for other languages in the future (I plan on implementing types for Go imminently).
The only change introduced by this PR is to exit early from the function if a fetch fails, rather than performing all the fetches then going though the errors one by one. Should mildly increase performance for the unhappy path, though it was more to make the code easier to follow.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
Behaviour not changed.
What is the new behavior?
Behaviour not changed.