fix: query timeout #768
Merged
fix: query timeout #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamhieu
approved these changes
May 2, 2024
darora
reviewed
Jun 11, 2024
| @@ -43,7 +43,7 @@ export const GENERATE_TYPES_DETECT_ONE_TO_ONE_RELATIONSHIPS = | |||
|
|
|||
| export const DEFAULT_POOL_CONFIG: PoolConfig = { | |||
| max: 1, | |||
| connectionTimeoutMillis: PG_CONN_TIMEOUT_SECS * 1000, | |||
| query_timeout: PG_CONN_TIMEOUT_SECS * 1000, | |||
There was a problem hiding this comment.
A connection timeout is not a query timeout. imo it's very misleading to feed in a "CONN_TIMEOUT" here.
There was a problem hiding this comment.
Good catch, made a PR to revert it: #777
darora
reviewed
Jun 11, 2024
| @@ -43,7 +43,7 @@ export const GENERATE_TYPES_DETECT_ONE_TO_ONE_RELATIONSHIPS = | |||
|
|
|||
| export const DEFAULT_POOL_CONFIG: PoolConfig = { | |||
| max: 1, | |||
| connectionTimeoutMillis: PG_CONN_TIMEOUT_SECS * 1000, | |||
There was a problem hiding this comment.
Removing this results in the default of 0 taking over - which is not what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Testing locally,
select pg_sleep(<forever>)just hangs even past theconnectionTimeoutMillisWhat is the new behavior?
Use
query_timeoutinstead which returnsQuery read timeoutwith a 400