Skip to content

fix: Close both apps to allow for process restart #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: Close both apps to allow for process restart #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/server/admin-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { fastify, FastifyInstance, FastifyServerOptions } from 'fastify'

import FastifyMetrics from 'fastify-metrics'
import fastifyMetrics from 'fastify-metrics'

export function build(opts: FastifyServerOptions = {}): FastifyInstance {
const app = fastify(opts)
// @ts-ignore fastify-metrics doesn't work with NodeNext resolution
app.register(FastifyMetrics, {
app.register(fastifyMetrics.default, {
endpoint: '/metrics',
routeMetrics: { enabled: false },
})
Expand Down
6 changes: 6 additions & 0 deletions src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,15 @@ if (EXPORT_DOCS) {
app.log.error(err)
}
await app.close()
await adminApp.close()
})
app.addHook('onClose', async () => {
closeListeners.uninstall()
await adminApp.close()
})
adminApp.addHook('onClose', async () => {
closeListeners.uninstall()
await app.close()
})

app.listen({ port: PG_META_PORT, host: PG_META_HOST }, (err) => {
Expand Down