chore: dedup typescript typegen logic #993
Open
+282
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Sep 24, 2025
Comment on lines
620
to
633
| export const Constants = { | ||
| ${schemas | ||
| .sort(({ name: a }, { name: b }) => a.localeCompare(b)) | ||
| .map((schema) => { | ||
| const schemaEnums = types | ||
| .filter((type) => type.schema === schema.name && type.enums.length > 0) | ||
| .sort(({ name: a }, { name: b }) => a.localeCompare(b)) | ||
| return `${JSON.stringify(schema.name)}: { | ||
| ${schemas.map((schema) => { | ||
| const schemaEnums = introspectionBySchema[schema.name].enums | ||
| return `${JSON.stringify(schema.name)}: { | ||
| Enums: { | ||
| ${schemaEnums.map( | ||
| (enum_) => | ||
| `${JSON.stringify(enum_.name)}: [${enum_.enums | ||
| .map((variant) => JSON.stringify(variant)) | ||
| .join(', ')}]` | ||
| )} | ||
| } | ||
| }` | ||
| })} | ||
| })} |
There was a problem hiding this comment.
note
Forgot to remove this loop, now we can use the introspectionSchema directly where the values are already filtered and sorted.
Comment on lines
-234
to
-240
| ${relationships | ||
| .filter( | ||
| (relationship) => | ||
| relationship.schema === table.schema && | ||
| relationship.referenced_schema === table.schema && | ||
| relationship.relation === table.name | ||
| ) |
There was a problem hiding this comment.
note
Noticed that I forgot this loop, instead I now push those into the introspectedSchema object under each table/view so we don't have to filter and sort everytime.
Also extracted the typegen into it's own dedicated function reducing duplication across tables/views definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?