fix: run nix-gc before pg_upgrade #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebengeu
approved these changes
Sep 9, 2024
| curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix | sh -s -- install --no-confirm \ | ||
| --extra-conf "substituters = https://cache.nixos.org https://nix-postgres-artifacts.s3.amazonaws.com" \ | ||
| --extra-conf "trusted-public-keys = nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=% cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=" | ||
| if [ ! -f /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh ]; then |
There was a problem hiding this comment.
Nit: && with above into one condition?
There was a problem hiding this comment.
That would unfortunately never run :[
The nix binary is generally located in /root/.nix-profile/bin - with the path provided by sourcing /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
In truth, if /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh doesn't exist, neither will /root/.nix-profile/bin/nix, which makes ! command -v nix > /dev/null kind of superfluous.
Will remove the secondary check once we figure out the avenue of hosting the installer ourselves, as I'm not sure how stable the /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh path is at the moment
darora
approved these changes
Sep 10, 2024
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.