-
-
Notifications
You must be signed in to change notification settings - Fork 200
move orioledb to extensions schema #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c9eecc4
to
cd6234a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work as expected with restores and unpauses?
@darora thanks for the approval, I should have noted that we are going to hold off on merging this until I test restore, unpause. That should be done by end of day tomorrow, and then will set an actual vars.yml release version, and pr for rollout. Oliver stated that this does not require rollout to existing instances. But our policy now is to always test pause/unpause and restore, so will be doing that for sure. |
This change targets orioledb moving installed orioledb extension from "public" schema to "extensions" schema
tested and confirmed no failures on pause/restore. Per @olirice this doesn't actually need to apply the sql migration on an existing project. But the migration succeeds on new project. |
* chore: move orioledb to extensions scehama * ore: update schemas * chore: create testing AMI images * chore: bump version for release This change targets orioledb moving installed orioledb extension from "public" schema to "extensions" schema
What kind of change does this PR introduce?
Moves the orioledb extension to the extensions schema if:
orioledb is enabled in the public schema
the extensions schema exists
This is important because orioledb exposes some entities that we don't necessarily want exposed over APIs by default
Recommending we use this PR instead of #1433 as it is more up to date CI, less hassle toward reconciling git changes