-
-
Notifications
You must be signed in to change notification settings - Fork 201
feat: reland vault w/o pgsodium #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 447f449.
849d90c
to
073e79b
Compare
073e79b
to
193941e
Compare
Just wanted to check the status of this; we need vault 0.3.1 since it fixes a bug where secrets cannot be empty. Any updates? |
Hey @barrownicholas, this should be available on new & upgraded projects in a few weeks |
REENCRYPT_VAULT_SECRETS_QUERY=$(cat <<EOF | ||
DO \$\$ | ||
BEGIN | ||
IF EXISTS (SELECT FROM pg_available_extension_versions WHERE name = 'supabase_vault' AND version = '0.3.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be 0.3.0?? The PR is bumping it from 0.2.9 to 0.3.1, where does 0.3.0 come in from?
Also it feels like this patch would need to be executed even if in the future we were on e.g. 0.3.2, and we're likely going to forget to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the query runs for all versions >= 0.3.0. Vault >=0.3.1 would still have 0.3.0 in pg_available_extension_versions
@doublethink @staaldraad can you please have a look at this to make sure you don't see any known security issues with these changes, and thanks! |
* Reapply "feat: vault sans pgsodium" This reverts commit 447f449. * chore: update schema snapshots * chore: print regress diffs for easier debugging * chore: remove pgsodium priv checks * fix: move it out of if else * chore: bump version * chore: bump version
Reland #1431; the migration has been merged in #1442
Tested flows on local infra:
drop extension supabase_vault cascade;
select * from vault.decrypted_secrets
select * from vault.decrypted_secrets
drop extension pgsodium
select * from vault.decrypted_secrets
select * from vault.decrypted_secrets