Skip to content

chore: address possible race conditions encountered when running a PG upgrade #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

chore: address possible race conditions encountered when running a PG upgrade #629

merged 1 commit into from
May 3, 2023

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented May 2, 2023

  • If project was previously updated, the poll script might return previous upgrade complete status
  • Kernel might not register newly attached disk's partition table - waiting and running an explicit check & repair forces it to properly register the new volume

@pcnc pcnc requested a review from a team as a code owner May 2, 2023 17:01
supaPatrick
supaPatrick approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@supaPatrick supaPatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcnc pcnc merged commit 3330891 into develop May 3, 2023
@pcnc pcnc deleted the pcnc/upgrade-script-race-condition branch May 3, 2023 07:27
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
@pcnc
chore: fix race conditions when running a pg upgrade (supabase#629)
37d3413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darora darora darora approved these changes

+1 more reviewer

@supaPatrick supaPatrick supaPatrick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcnc @darora @supaPatrick