Skip to content

chore: fix and enable pljava #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

chore: fix and enable pljava #690

wants to merge 13 commits into from

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented Jul 5, 2023

  • Enables pljava
  • Some project upgrades were failing since the extension was missing in the upgrade binaries (and in the distribution itself), and databases targeted for upgrade had pljava enabled

@pcnc pcnc force-pushed the pcnc/fix-pljava branch 2 times, most recently from 1c3bc6e to 2720623 Compare July 5, 2023 16:05
@pcnc pcnc force-pushed the pcnc/fix-pljava branch from 2720623 to 7a77831 Compare July 5, 2023 16:14
@@ -1,3 +1,3 @@
BEGIN;
create extension if not exists pljava with schema "sqlj";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pljava creates the sqlj schema automatically

@@ -80,11 +82,12 @@ jobs:
ubuntu_release_no=${{ matrix.ubuntu_version }}
postgresql_major=${{ steps.version.outputs.postgresql_major }}
postgresql_release=${{ steps.version.outputs.postgresql_release }}
CPPFLAGS=-mcpu=${{ matrix.mcpu }}
CPPFLAGS=
DEB_BUILD_PROFILES=pkg.postgresql.nozstd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building Postgres from source requires libzstd 1.4.0+, whereas Ubuntu 18 only has versions up to 1.3.3 available.
Sadness all around, although it doesn't affect us since these binaries are only used to upgrade from PG13/14 (which didn't have zstd compression support)

@@ -46,6 +46,8 @@ jobs:
- uses: docker/setup-buildx-action@v2
with:
endpoint: builders
driver-opts: image=moby/buildkit:v0.11.6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated buildkit just in case it'd help us avoid connection reset errors; default was running under v0.10.0

@@ -56,7 +58,7 @@ jobs:
tags: supabase/postgres:extensions
platforms: linux/${{ matrix.arch }}
cache-from: type=gha
cache-to: type=gha,mode=max
cache-to: type=gha,mode=max,ignore-error=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no point crashing the entire workflow if the build cache push fails

ADD --checksum=${pljava_release_checksum} \
"https://github.com/supabase/pljava/archive/refs/heads/${pljava_release}.tar.gz" \
"https://github.com/tada/pljava/archive/refs/tags/V${pljava_release}.tar.gz" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting to original repo since PG15 support was merged in the meantime

@pcnc pcnc marked this pull request as ready for review July 5, 2023 20:18
@pcnc pcnc requested review from a team as code owners July 5, 2023 20:18
Copy link
Contributor

@darora darora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tested pause/restore and upgrades from older builds that had pljava enabled?

…ss` when building the .deb for pljava

Co-authored-by: Han Qiao <qiao@supabase.io>
@pcnc
Copy link
Member Author

pcnc commented Jul 6, 2023

We've tested pause/restore and upgrades from older builds that had pljava enabled?

Not yet - this is pending today - upgrades breaking were the main driver for this PR

@pcnc pcnc requested a review from a team as a code owner February 5, 2024 12:16
@pcnc pcnc closed this Mar 20, 2024
samrose added a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants