Chore: adding sysctl params for rebooting the OS after oomkiller kill… #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darora
approved these changes
Oct 17, 2023
| - name: Set vm.panic_on_oom=1 | ||
| ansible.builtin.sysctl: | ||
| name: vm.panic_on_oom | ||
| value: '1' |
There was a problem hiding this comment.
Do we want 2? I guess 1 is fine right now since PG memory usage is not capped?
There was a problem hiding this comment.
I thought 1 seemed better sense we aren't using cgroups.
There was a problem hiding this comment.
Some of our services use systemd resource controls (e.g. https://github.com/supabase/postgres/blob/develop/ansible/files/gotrue.service.j2#L13) which internally uses cgroups afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding sysctl params to restart the system on OOM.
tested the machine does restart on OOM.
Please go the the
Previewtab and select the appropriate sub-template: