Skip to content

chore: remove plv8 from exclusions #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2023
Merged

chore: remove plv8 from exclusions #813

merged 2 commits into from
Dec 9, 2023

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented Nov 30, 2023 •
edited
Loading

  • keeps plv8 around when upgrading

@pcnc pcnc requested a review from a team as a code owner November 30, 2023 12:39
@bmpandrade
Copy link
Contributor

bmpandrade commented Nov 30, 2023 •
edited
Loading

test-ami was failing with

==> amazon-ebssurrogate.source: Error deregistering existing AMI: UnauthorizedOperation: 
You are not authorized to perform this operation. 
User: arn:aws:sts::436098097459:assumed-role/internal-actions-runners-role/1701348762036699624 is 
not authorized to perform: ec2:DeregisterImage on resource: 
arn:aws:ec2:ap-southeast-1::image/ami-0e35fa03abcc1b9e7 because no 
identity-based policy allows the ec2:DeregisterImage action.

Since there was another PRs with similar issues, that seem to already been fixed, I've triggered a re-run on the failed job.

darora
darora approved these changes Dec 1, 2023
View reviewed changes
ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh Outdated
# i.e.
# - old version: wrappers-0.1.16.so
# - new version: wrappers-0.1.18.so
# - workaround to make pg_upgrade happy: copy wrappers-0.1.18.so to wrappers-0.1.16.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels so wrong, and is going to be hard to debug post-hoc. I take it that symlinks don't work?

If they don't, maybe we can touch a hidden file indicating what we've done as part of the upgrade?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symlinks should work, as they're regularly used by lib files. Switching to use symlinks

@pcnc pcnc force-pushed the pcnc/update-scripts branch from 909bb82 to 0117a65 Compare December 9, 2023 08:07
@pcnc pcnc changed the title chore: remove plv8 from exclusions; handle versioned lib names chore: remove plv8 from exclusions Dec 9, 2023
@pcnc pcnc merged commit c7e3319 into develop Dec 9, 2023
@pcnc pcnc deleted the pcnc/update-scripts branch December 9, 2023 08:08
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
@pcnc
chore: remove plv8 from exclusions (supabase#813)
323f0e6 
* chore: remove plv8 from exclusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darora darora darora approved these changes

+1 more reviewer

@bmpandrade bmpandrade bmpandrade approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcnc @bmpandrade @darora