This repository was archived by the owner on Oct 9, 2025. It is now read-only.
fix: Fetch method can't handle error response that is not a valid JSON #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
suggested changes
Jan 12, 2022
Comment on lines
127
to
134
| error = await res.json() | ||
|
|
||
| if (error && this.shouldThrowOnError) { | ||
| throw error | ||
| try { | ||
| error = await res.json() | ||
| } catch (e) { | ||
| error = await res.text() | ||
| } finally { | ||
| if (error && this.shouldThrowOnError) { | ||
| throw error | ||
| } |
There was a problem hiding this comment.
We can't reuse the response body since it was consumed with res.json(). Also, we want the error to be an object with a message property. So how about:
const body = await res.text()
try {
error = JSON.parse(body)
} catch {
error = {
message: body
}
}
if (error && this.shouldThrowOnError) {
throw error
}
|
Hey @BigOsvaap, just realized we urgently need the fix so I'll merge this + my suggestion in. Thanks again for the PR! |
soedirgo
approved these changes
Jan 12, 2022
|
🎉 This PR is included in version 0.35.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
The fetch method tries to parse error response as JSON before returning. Whenever the error response is not a JSON object, it will not return properly instead a JSON parsing error will be thrown.
What is the new behavior?
The fetch method tries to parse error response as JSON before returning, in case of failure returns a raw text error.
Additional context
Fix #241