This repository was archived by the owner on Oct 9, 2025. It is now read-only.
Export PostgrestResponseSuccess and PostgrestResponseFailure #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjrocker
force-pushed
the
export-response-types
branch
from
cafe145 to
8f1232d
Compare
kjrocker
force-pushed
the
export-response-types
branch
from
8f1232d to
6bd4b04
Compare
|
This would be convenient for me too. |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Type change. Discussion here: supabase/supabase#12228
What is the current behavior?
Only the top-level
PostgrestResponsetypes are exported.What is the new behavior?
Export the sub-types that go into
PostgrestResponsefor type-union/guard-clause purposes.Additional context
I noticed the plan is to rename
PostgrestSingleResponseand deprecate the currentPostgrestResponse, so instead of exportingPostgrestSingleResponseSuccessunder its current name I went withPostgrestResponseSuccess.This might mean holding the change back until v3, but since its to a (formely) internal type we should be okay.