Add support for type casting (id::text) #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozanmakes
force-pushed
the
add-support-for-type-casting
branch
2 times, most recently
from
249e707
to
c9b9c89
Compare
This change adds support for type casting in select queries. For example an id column with the type bigint can be casted to text by "id::text". Equivalent PostgreSQL type for TypeScript type is based on the type generator pgTypeToTsType function https://github.com/supabase/postgres-meta//blob/80809c71d78d875524d7d9865c2458136207aa10/src/server/templates/typescript.ts#L421 Fixes supabase#370
ozanmakes
force-pushed
the
add-support-for-type-casting
branch
from
c9b9c89
to
2fcd68f
Compare
2 tasks
|
Hi @soedirgo. Any chance this can be reviewed? |
steve-chavez
approved these changes
Feb 7, 2024
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This change adds support for type casting in select queries. For example an id column with the type bigint can be casted to text by "id::text".
Equivalent PostgreSQL type for TypeScript type is based on the type generator pgTypeToTsType function.
What is the current behavior?
Fixes #370
What is the new behavior?
id::textwill cast abigintcolumn tostringin TypeScript._textwill betext[].newname:id::textwill also workAdditional context
This is by no means a complete list of all possible type casts nor is it sound, but this is much less error prone than having to do an unsafe cast such as