-
-
Notifications
You must be signed in to change notification settings - Fork 63
Namespace change #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace change #114
Conversation
We were earlier modifying session.headers/session.params for every query. Instead of this we follow what postgrest-js does and add headers and params as arguments to the query builders, and pass them down the chain of builders, and finally pass it to the execute method.
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 2.84%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 92.25% 92.78% +0.52%
==========================================
Files 22 23 +1
Lines 930 942 +12
==========================================
+ Hits 858 874 +16
+ Misses 72 68 -4
Continue to review full report at Codecov.
|
If we make a release now, I think it should be v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for putting this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Lgmt!
This PR changes the namespace from
postgrest_py
topostgrest
.Other changes: