Skip to content

Conversation

edgurgel
Copy link
Member

What kind of change does this PR introduce?

Use just gen_rpc for pubsub broadcasting.

In the near future we can drop the broadcast_adapter column

What is the current behavior?

Rely on broadcast_adapter to decide between Phoenix (erl dist) or gen_rpc to broadcast to the database.

What is the new behavior?

Always use gen_rpc

Additional context

Add any other context or screenshots.

Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored Preview Aug 11, 2025 10:31pm

@edgurgel edgurgel force-pushed the fix/gen-rpc-broadcast branch from 6278bbc to f2410f2 Compare August 11, 2025 00:31
@coveralls
Copy link

coveralls commented Aug 11, 2025

Coverage Status

coverage: 84.283% (-0.3%) from 84.533%
when pulling b48d43d on fix/gen-rpc-broadcast
into f4b2965 on main.

@edgurgel edgurgel force-pushed the fix/gen-rpc-broadcast branch from f2410f2 to b48d43d Compare August 11, 2025 22:31
@edgurgel edgurgel merged commit 9aed839 into main Aug 11, 2025
6 of 7 checks passed
@edgurgel edgurgel deleted the fix/gen-rpc-broadcast branch August 11, 2025 22:50
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.41.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants