Skip to content

Conversation

inian
Copy link
Member

@inian inian commented Aug 10, 2022

signedURL used to return a url directly and inside the data object. This is inconsistent. Now we always return values inside a data object only.

signedURL used to return a url directly and inside the data object. This is inconsistent. Now we always return values inside a data object only.
@inian inian requested a review from alaister August 10, 2022 05:24
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@inian inian merged commit 93dfb9c into next Aug 10, 2022
@inian inian deleted the signed-url-return branch August 10, 2022 05:40
@kiwicopple
Copy link
Member

🎉 This PR is included in version 1.8.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants