Skip to content

Conversation

itslenny
Copy link
Contributor

@itslenny itslenny commented Jul 2, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

S3 only allows 5000 parts for multi-part uploads

What is the new behavior?

Allow 10,000 parts for multi-part uploads

@itslenny itslenny force-pushed the fix/allow-10000-parts-for-s3 branch from cdbe80a to db76afa Compare July 2, 2025 13:42
@itslenny itslenny closed this Jul 2, 2025
@itslenny itslenny deleted the fix/allow-10000-parts-for-s3 branch July 2, 2025 13:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16026810109

Details

  • 175 of 223 (78.48%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 77.918%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/database/knex.ts 31 32 96.88%
src/storage/events/workers.ts 2 3 66.67%
src/storage/storage.ts 24 26 92.31%
src/internal/errors/codes.ts 2 8 25.0%
src/storage/events/objects/object-admin-delete-all-before.ts 103 141 73.05%
Totals Coverage Status
Change from base Build 15879228188: -0.002%
Covered Lines: 17596
Relevant Lines: 22414

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants