feat: add EventTypes as a Type #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔥 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I've merged this, but now that I think about it, this should probably be in our realtime-js library - Unfortunately it got released before I thought harder. Don't do PR's before coffee. |
|
Hey @kiwicopple, Don’t worry, this is how life works, first we do it, then we think and improve it 🚀 Where (path) exactly do you think this file should be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add a new Type to avoid use duplicated code.
What is the current behavior?
We're duplicating code for lack of specific data type.
What is the new behavior?
Creating this new type, we can remove the duplicated code using the new created type.
Additional context
JS is amazing, isn't?