Skip to content

Conversation

ftonato
Copy link
Contributor

@ftonato ftonato commented Jan 14, 2021

What kind of change does this PR introduce?

This PR will help us to reduce the complexity of the SupabaseRealtimeClient and SupabaseClient classes splitting our current code.

What is the current behavior?

  • SupabaseRealtimeClient -> getPayloadRecords method complexity is 10.
  • SupabaseClient class complexity is 11.
    • SupabaseClient -> removeSubscription method complexity is 11.

What is the new behavior?

SupabaseRealtimeClient -> getPayloadRecords method complexity will be 7.

  • SupabaseClient class complexity will be 10.
    • SupabaseClient -> removeSubscription method complexity is 10.

Additional context

@kiwicopple
Copy link
Member

🔥

@kiwicopple kiwicopple merged commit 02c1ddd into supabase:master Jan 15, 2021
@kiwicopple
Copy link
Member

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants