fix(storage): remove trailing slash from baseUrl normalization #1589
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
When configuring baseUrl for StorageBucketApi, if the API endpoint is a host-only URL (e.g., http://localhost:5000), using new URL(...).href automatically normalizes it to include a trailing slash (http://localhost:5000/).
What changed?
Remove tailing slash for
baseUrl.href
Why was this change needed?
During local development of Supabase Storage, the base URL is set to http://localhost:5000. I encountered issues when calling the local API from the JS SDK.
Closes #1588
📸 Screenshots/Examples
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>
npx nx format
to ensure consistent code formatting📝 Additional notes
None