fix: do not cache Authorization header (and add tests) #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
approved these changes
Mar 30, 2022
mandarini
pushed a commit
that referenced
this pull request
Oct 2, 2025
We were using mocha which presented some challenges and less than good experience when it came to testing. We're moving to vitest and we're also using Typescript in our testing to easily catch some of the typing issues that might arise earlier. We're also adding a coverage so later we can setup CI to take that into consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#402 caused a regression in the client that will cache the initial Authorization header
What is the new behavior?
Still allows overriding the Authorization header, but otherwise will use the value from
auth.session()