fix: clear this.changedAccessToken after signOut #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
pushed a commit
that referenced
this pull request
Oct 2, 2025
mandarini
added a commit
that referenced
this pull request
Oct 2, 2025
* chore: do not fail on coveralls error * chore: eol --------- Co-authored-by: Bobbie Soedirgo <31685197+soedirgo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Resolves the last remaining issue of, and closes supabase/auth-js#524
What is the current behavior?
After a user is logged out, the supabase-js client's
changedAccessTokenproperty still contains the user's jwt.What is the new behavior?
this.changedAccessTokenis set toundefined, per typing.Additional context
If a
TOKEN_REFRESHEDorSIGNED_INevent occurs,_handleTokenChangedsetsthis.changedAccessToken(under the proper conditions). So I assume_handleTokenChangedis the place to unsetthis.changedAccessTokenif aSIGNED_OUTevent occurs.