Skip to content

Conversation

duncanhealy
Copy link
Contributor

  • exclude node_modules from tsconfig
  • add types export to package.json add types-generate command

@kiwicopple
Copy link
Member

This is cool @duncanhealy - I'm guessing we run this every time we deploy to NPM?

If so, we have a few options:

  • add it to the GitHub action
  • add types-generate to the build command
  • change types-generate to build:types and it will get picked up automatically by the build command.

@duncanhealy
Copy link
Contributor Author

The tsc commands are already outputting the index.d.ts
but it is a little different to the dts-gen output (more fine-grained)
I like to use it for sanity check for the build output like the fixtures / snapshots for jest
if the output changes then you have a breaking change in your library
different surface, can bump minor/major version accordingly

and webpack is using ts-loader so all should be good

tsc should fail in ci.yml

tsc -p tsconfig.json should have failed before
but it may have been the upstream libs (in node_modules) that failed so that shouldn't happen anymore

@kiwicopple kiwicopple merged commit 7f82bf3 into supabase:master Nov 22, 2020
@kiwicopple
Copy link
Member

🎉 This PR is included in version 1.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

mandarini pushed a commit that referenced this pull request Oct 2, 2025
Directly pass through event streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants