chore(CI): drop pre-commit #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooks this should ensure that pre-commit does not install the same tools (ruff) with different versions and cause weird mismatch errors with the ones from uv.
grdsdev
approved these changes
Oct 1, 2025
Pull Request Test Coverage Report for Build 18168301904Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Drop the pre-commit tool, by doing the same command calls through uv directly instead. Currently,
ruffis installed through pre-commit, instead of by uv, which may cause differences in versions between those. pre-commit is also very slow, and is only used to run ruff. The checks from pre-commit-hooks that are removed are all covered by ruff check/ruff format. It doesn't really make sense to run commitizen manually so I didn't bother adding a target for that, but I did add one for ruff, in order to run it in CI too.Also added make install-hooks to remove the need to pre-commit install.