fix(auth): make AuthClient an Actor #664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
AuthClient
class inSources/Auth/AuthClient.swift
to improve concurrency handling and integrate Combine for handling app lifecycle changes.Concurrency improvements:
AuthClient
from afinal class
to anactor
to leverage Swift's concurrency model.To keep backward compatibility, had to mark a few properties and methods of
AuthClient
asnonisolated
, thenonisolated
mark, shall be removed on a next major release.Combine integration:
Because of the change from class to actor, I had to change the way we observe the notification center.
Combine
import conditionally based on availability.observeAppLifecycleChanges
to use Combine publishers for handling app lifecycle notifications.These changes improve the concurrency model of
AuthClient
and modernize the handling of app lifecycle events using Combine.