Skip to content

feat: command to query a table #28683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: command to query a table #28683

merged 2 commits into from
Sep 12, 2024

Conversation

charislam
Copy link
Contributor

@charislam charislam commented Aug 15, 2024

Creates this subpage:

image

Selecting a table brings you to the SQL editor with this prefilled:

image

Copy link

supabase bot commented Aug 15, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 9:34pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:34pm
studio ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:34pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:34pm
docs ⬜️ Skipped (Inspect) Sep 12, 2024 9:34pm
zone-www-dot-com ⬜️ Skipped (Inspect) Sep 12, 2024 9:34pm

@charislam charislam marked this pull request as ready for review August 15, 2024 21:56
@charislam charislam requested a review from a team as a code owner August 15, 2024 21:56
@joshenlim
Copy link
Member

joshenlim commented Aug 16, 2024

hahaha caught this in my previous stress testing scenarios 😂
im guessing the highlighting logic is ignoring cases on the table name?
and also wondering why some table names are wrapped in double quotes too
image

my table names give this vibe 😂
image

@charislam
Copy link
Contributor Author

@joshenlim

my table names give this vibe 😂

I love it 😂

good catch with the highlighting, nice stress testing there

I quoted all identifiers that need to be quoted in SQL, in the interest of "educating users about SQL" (didn't feel right to write it as schema.tableName when it's not valid), but I guess we don't do that anywhere else in the dashboard, so I'll take it out

@charislam charislam force-pushed the feat/query-table-command branch from 229eb06 to 677c69e Compare September 4, 2024 15:58
@vercel vercel bot temporarily deployed to Preview – docs September 4, 2024 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com September 4, 2024 15:58 Inactive
@charislam
Copy link
Contributor Author

@joshenlim should be fixed now!

@jordienr
Copy link
Member

lgtm! tested in preview environment

@charislam charislam merged commit ed73af2 into master Sep 12, 2024
14 checks passed
@charislam charislam deleted the feat/query-table-command branch September 12, 2024 22:12
encima pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants